[ 
https://issues.apache.org/jira/browse/TOMAHAWK-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602261#action_12602261
 ] 

Paul Spencer commented on TOMAHAWK-1023:
----------------------------------------

I have no objections to #2 as long as the test is a valid test.

Please note the test cases use renderers defined in 
org.apache.myfaces.test.utils.TestUtils.addDefaultRenderers() [1].  This is 
because Shale-test 1.0.x does not read faces.xml. Shale-262 [2] resolves this 
issue in version 1.1.
 


[1]http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/core/src/test/java/org/apache/myfaces/test/utils/TestUtils.java?view=markup
[2]http://issues.apache.org/struts/browse/SHALE-262

> HtmlInputHidden fails unit test when using RI
> ---------------------------------------------
>
>                 Key: TOMAHAWK-1023
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1023
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>    Affects Versions: 1.1.6, 1.1.7-SNAPSHOT
>            Reporter: Paul Spencer
>             Fix For: 1.1.7-SNAPSHOT
>
>
> -------------------------------------------------------------------------------
> Test set: org.apache.myfaces.component.html.ext.HtmlInputHiddenTest
> Below are output from the test failures. The test are run using the following 
> command:
>    cd tomahawk/core
>    mvn test -Djsf=ri 
> -------------------------------------------------------------------------------
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.016 sec <<< 
> FAILURE!
> testDefaultRenderer(org.apache.myfaces.component.html.ext.HtmlInputHiddenTest)
>   Time elapsed: 0.016 sec  <<< FAILURE!
> junit.framework.AssertionFailedError: ID is not null
>       at junit.framework.Assert.fail(Assert.java:47)
>       at junit.framework.Assert.assertTrue(Assert.java:20)
>       at junit.framework.Assert.assertNotNull(Assert.java:220)
>       at 
> org.apache.myfaces.test.AbstractTomahawkViewControllerTestCase.assertIdExists(AbstractTomahawkViewControllerTestCase.java:88)
>       at 
> org.apache.myfaces.component.html.ext.HtmlInputHiddenTest.testDefaultRenderer(HtmlInputHiddenTest.java:64)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to