On Thu, Jun 19, 2008 at 2:00 PM, simon <[EMAIL PROTECTED]> wrote: > Hi All, > > All of the following now build ok: > * core1.1 > * Tomahawk1.1 > * Tomahawk sandbox 1.1 > * Tomahawk sandbox15 > And the tomahawk examples seem to run ok. >
Thanks Simon, I'll update myfaces commons templates as well (I'm waiting this for start commit some code related to MYFACES-434). > > Core 1.2 also builds fine, although I haven't tested the results. > > I'm a bit puzzled about the new tomahawk1.2 stuff. It looks like some > "unpack" goal is being run using myfaces-builder-plugin but I cannot > find any code in the myfaces-builder-plugin project for this. Where is > it? > look the package on myfaces builder plugin: org.apache.myfaces.buildtools.maven2.plugin.builder.unpack The code has also some comments. > The tomahawk1.2 build is also failing with some odd message, but I'll > need to figure out what the build is actually doing to make any progress > there. Or maybe you could take a look Leonardo? > I'll check this stuff. no prob. > > I'm currently working on a simple tool that will "normalize" a tld or > faces-config file: > * strip comments > * strip description fields > * sort elements somehow > Then we can easily compare the tld and faces-config.xml being generated > now with the ones from the last release to verify that everything is as > expected. We could also compare against other JSF releases to ensure > that things are consistent. Having this as a maven plugin would be quite > nice but I won't initially bother; just a command-line tool will be > enough. > Cool! +1. > > Regards, > Simon > > > On Thu, 2008-06-19 at 00:05 +0200, simon wrote: > > Ok, templates are updated and core11 builds fine. > > > > There is still a problem with building Tomahawk; the parentClass > > property is not being set for some classes because the parent class > > cannot be found for some reason. The new sanity checking picks that up > > and reports the error. Of course core doesn't inherit any data from > > other projects, so doesn't fail. > > > > Regards, > > Simon > > > > On Tue, 2008-06-17 at 23:04 +0200, simon wrote: > > > I've made some changes to ClassMeta and QdoxModelBuilder. > > > > > > What used to be called "superClassName" is now called > > > sourceClassParentClassName. However before it was actually tweaked > > > depending on whether the class was a template or not. Now it is > *always* > > > the parent of the annotated class > > > > > > That does mean the templates need to be updated. Unfortunately I've run > > > out of time tonight. Sorry about that. I will try to get this sorted as > > > soon as I can tomorrow. However just FYI, the template change needed > > > should be something like this I think: > > > > > > #if ($component.template) > > > #set ($parent = $component.sourceClassParentClassName > > > #else > > > #set ($parent = $component.sourceClassName) > > > #end > > > > > > public class ... extends $parent > > > > > > Or that logic could be in the utils class. > > > > > > Regards, > > > Simon > > > > > > >
