On Fri, 2008-06-20 at 15:45 +0200, simon wrote: > I have my "tld comparator" running, and have compared myfaces_core.tld > for versions 1.1.5 and 1.1.6-SNAPSHOT (ie the current output). > > The following differences were detected: > * missing xmlns on <taglib> element > > And the following classes are missing all attributes: > * ParamTag > * SelectItemTag > * SelectItemsTag > * SubviewTag > * ValidateDoubleRange > * ValidateLength > * ValidateLongRange > > > I'm not quite sure what is going wrong there. The generated TLD file has > things like > &ui_parameter_attributes; > which appears to be something from the old TLD generation approach, and > I can't yet see where that is coming from.
Ok, namespace fixed. Not sure what caused those funny tag problems; that just went away. I have done some more tld checking, and here are the (partial) results comparing myfaces 1.1.5 with 1.1.6-snapshot: (1) for myfaces_core.tld == attribute types We now output type=String for many attributes that previously had no type. Example: ActionListenerTag.type or LoadBundleTag.var This seems ok to me. == ValidatorTag Property validatorId was previously required=false. It is now required=true. This looks like a bug in Core 1.1.5, and that the snapshot is correct. == ValueChangeListenerTag Property "type" was previously required=true. It is now required=false. This looks like a bug in 1.1.6-snapshot. I have fixed it. (2) for myfaces_html.dtd == h:commandButton Has a "size" attribute in 1.1.5 that is no longer there in 1.1.6-SNAPSHOT. Sun has no such attribute, so I presume that is a bug in 1.1.5 and 1.1.6-SNAPSHOT is correct. == HtmlDataTableTag The 1.1.5 core release defined the following attributes that are no longer there in 1.1.6-SNAPSHOT: * align * datafld * datasrc * dataformatas Sun has none of these, so I presume that is a bug in 1.1.5. == HtmlInputSecretTag Has an "align" attribute in 1.1.5 that is no longer there in 1.1.6-SNAPSHOT. Sun has no such attribute, so I presume that is a bug in 1.1.5 and 1.1.6-SNAPSHOT is correct. * same for HtmlInputTextTag == HtmlInputTextArea Has the following fields in 1.1.5 that are no longer there in 1.1.6-SNAPSHOT: * datafld * dataformatas * datasrc == HtmlMessageTag: Had the following in 1.1.5: * dir * lang * onclick/ondblclick/onkeydown/onkeypress/onkeyup/onmouse* == HtmlMessagesTag * dir * lang * onclick/ondblclick/onkeydown/onkeypress/onkeyup/onmouse* plus more stuff I haven't checked yet. So what should we do about all these attributes that apparently we were exposing in the Core 1.1.5 tld which are not actually part of the JSF specification? Regards, Simon
