On Tue, Jun 24, 2008 at 1:52 PM, Leonardo Uribe <[EMAIL PROTECTED]> wrote: > > On Tue, Jun 24, 2008 at 3:05 PM, Volker Weber <[EMAIL PROTECTED]> wrote: >> >> Hi, >> >> >> converters should go into commons not into tomahawk.
+1 >> Why is this only planed for the 1.2 branch? > > That is the hidden reason why I request a vote for this. All validators and > converters should be on myfaces-commons. Almost all comes from tomahawk or > sandbox (EnumConverter and DateRestrictValidator available only on commons). > > Tomahawk has some validators defined on core: > > t:validateCreditCard > t:validateEmail > t:validateEqual > t:validateRegExpr let's move them over... > > This validators right now are defined on myfaces-commons. > > One question is if tomahawk core12 should have validators or converters > defined on its tld(but use the commons jar code), since the plan is that all > validators and converters should be on myfaces-commons. why not ? Just make it a RT dependency, and we are fine. > > Other question after answer the first is what should happen on core branch: > deprecate the actual defined validators and remove it from core12, but where > should be the sandbox converters and validators? or maybe define it on > commons jsf11 branch, move all validators and converters from tomahawk and > release a myfaces-commons-xxxx 1.1.0? . > > This is why before I proposed a discussion a vote about myfaces-commons > layout. There are many alternatives we can do on this topic, but we need to > be precise about what to do. > > The only thing clear is that myfaces commons jsf11 branch should be used > for backports only. well, if folks like to add stuff, why not? > > The vote proposed is my humble opinion about what to do, but if there are > better ideas about what to do is the right time to say it. > > Suggestions are welcome seriously, we are adding more and more and more to myfaces... it get's kinda jakarta like. It's hard to keep track of all the things. bad signal ? -Matthias > > regards > > Leonardo Uribe > >> >> Regards, >> Volker >> >> >> >> 2008/6/24 Leonardo Uribe <[EMAIL PROTECTED]>: >> > Hi >> > >> > The following converters and validators are proposed to be moven from >> > sandbox to tomahawk core: >> > >> > s:convertBoolean >> > s:convertDateTime >> > s:convertNumber >> > s:validateCompareTo >> > s:validateCSV >> > s:validateISBN >> > s:validateUrl >> > >> > In tomahawk core, the related files should be moved from sandbox/core to >> > core. In tomahawk core12, a new dependency to >> > myfaces-commons-converters >> > 1.2.x and myfaces-commons-validators 1.2.x should be added, so the >> > tomahawk >> > core12 tld reference validators and converters from these projects. This >> > introduce a change because >> > the validatorId and converterId for this components changes (because >> > this >> > converters are defined on myfaces-commons) only on core12. >> > >> > If you want to see this change on tomahawk please vote. >> > >> > This was discussed positively before, but the times change and better to >> > know what people think about it. >> > >> > Suggestions are welcome! >> > >> > regards >> > >> > Leonardo Uribe >> > >> > >> > >> >> >> >> -- >> inexso - information exchange solutions GmbH >> Bismarckstraße 13 | 26122 Oldenburg >> Tel.: +49 441 4082 356 | >> FAX: +49 441 4082 355 | www.inexso.de > > -- Matthias Wessendorf further stuff: blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf mail: matzew-at-apache-dot-org
