On Fri, Jun 27, 2008 at 12:19 PM, Leonardo Uribe <[EMAIL PROTECTED]> wrote:
> > > On Fri, Jun 27, 2008 at 11:56 AM, Leonardo Uribe <[EMAIL PROTECTED]> wrote: > >> >> >> On Fri, Jun 27, 2008 at 10:54 AM, simon <[EMAIL PROTECTED]> wrote: >> >>> Hi Leonardo, >>> >>> In the most recent commit to >>> https://svn.apache.org/repos/asf/myfaces/core/trunk/impl >>> you commented out the tlddocs report stuff in the "generate-site" >>> profile. >>> >>> As a result, the link from the main core11 site to the tlddocs gives a >>> blank page: >>> http://myfaces.apache.org/core11/myfaces-impl/tlddoc/index.html >>> >>> There were quite a few changes in that commit. Could you please take a >>> look and decide what should really happen here? >>> >> >> On generate-site section there exists three plugins: >> >> 1. the old xslt-maven-plugin that create the old tld (so this should be >> removed, because this is now generated by myfaces-builder-plugin) >> 2. reference to myfaces-builder-plugin to generate a tld (this should not >> be there, but is commented) >> 3. The code that generate the taglibdoc (I corrected the paths for tlds). >> >> I'm not review it in deep but this should work (it is the same on tomahawk >> core and sandbox). I can see the prob on the web site. Really before the >> change the tld doc was not generated (probe of this is the errors on the old >> tld). I'll test it and see waht happens. >> > > Running the goal we have this error: > > [ERROR] Unable to run tlddodc due to a class > com.sun.tlddoc.GeneratorException: > Error: > C:\GSOC\workspace\myfaces\current\core\impl\target\classes\META-INF\myfac > es_core.tld does not have xmlns="http://java.sun.com/xml/ns/javaee" > com.sun.tlddoc.GeneratorException: Error: > C:\GSOC\workspace\myfaces\current\core > \impl\target\classes\META-INF\myfaces_core.tld does not have xmlns=" > http://java. > sun.com/xml/ns/javaee" > at > com.sun.tlddoc.TLDDocGenerator.createTLDSummaryDoc(TLDDocGenerator.ja > va:555) > at > com.sun.tlddoc.TLDDocGenerator.generate(TLDDocGenerator.java:440) > at net.sf.maventaglib.TaglibdocMojo.execute(TaglibdocMojo.java:124) > at > net.sf.maventaglib.TaglibdocMojo.executeReport(TaglibdocMojo.java:157 > ) > at > org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMaven > Report.java:101) > at > org.apache.maven.plugins.site.ReportDocumentRenderer.renderDocument(R > eportDocumentRenderer.java:139) > at > org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule( > DefaultSiteRenderer.java:269) > at > org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(Defaul > tSiteRenderer.java:101) > at > org.apache.maven.plugins.site.SiteMojo.renderLocale(SiteMojo.java:129 > ) > at org.apache.maven.plugins.site.SiteMojo.execute(SiteMojo.java:96) > at > org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPlugi > nManager.java:447) > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(Defa > ultLifecycleExecutor.java:539) > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandalone > Goal(DefaultLifecycleExecutor.java:493) > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(Defau > ltLifecycleExecutor.java:463) > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHan > dleFailures(DefaultLifecycleExecutor.java:311) > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegmen > ts(DefaultLifecycleExecutor.java:278) > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLi > fecycleExecutor.java:143) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:333) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:126) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:282) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl. > java:39) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces > sorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:585) > at > org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315) > at org.codehaus.classworlds.Launcher.launch(Launcher.java:255) > at > org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430) > > at org.codehaus.classworlds.Launcher.main(Launcher.java:375) > > We have to remove xmnls reference from the <taglib> start tag (I did this > for tomahawk but not for myfaces core). > Tested and fixed. > > >> >>> One way or another, core1.1.x users do need taglib documentation.. >>> >>> Thanks, >>> Simon >>> >>> >> >
