On Fri, 2008-06-27 at 12:27 -0500, Leonardo Uribe wrote:

>                 
>                 On generate-site section there exists three plugins:
>                 
>                 1. the old xslt-maven-plugin that create the old tld
>                 (so this should be removed, because this is now
>                 generated by myfaces-builder-plugin)
>                 2. reference to myfaces-builder-plugin to generate a
>                 tld (this should not be there, but is commented)
>                 3. The code that generate the taglibdoc (I corrected
>                 the paths for tlds). 
>                 
>                 I'm not review it in deep but this should work (it is
>                 the same on tomahawk core and sandbox). I can see the
>                 prob on the web site. Really before the change the tld
>                 doc was not generated (probe of this is the errors on
>                 the old tld). I'll test it and see waht happens.
>                 
>         
>         Running the goal we have this error:
>         
>         [ERROR] Unable to run tlddodc due to a class
>         com.sun.tlddoc.GeneratorException:
>         Error: C:\GSOC\workspace\myfaces\current\core\impl\target
>         \classes\META-INF\myfac
>         es_core.tld does not have
>         xmlns="http://java.sun.com/xml/ns/javaee";
>         com.sun.tlddoc.GeneratorException: Error: C:\GSOC\workspace
>         \myfaces\current\core
>         \impl\target\classes\META-INF\myfaces_core.tld does not have
>         xmlns="http://java.
>         sun.com/xml/ns/javaee"
>                 at
>         com.sun.tlddoc.TLDDocGenerator.createTLDSummaryDoc(TLDDocGenerator.ja
>         va:555)
>                 at
<snip>
>         We have to remove xmnls reference from the <taglib> start tag
>         (I did this for tomahawk but not for myfaces core).
>         
> 
> Tested and fixed.

So the problem wasn't the commented-out block in the pom, but that the
namespace I added to the <taglib> element in the template causes the Sun
tlddoc generator to crash?

It does seem to be so, because the tlddoc report now builds. And I guess
that explains why sun's tlds don't have the namespace.

But it's weird for a couple of reasons:
(1) the previous core release *does* have a namespace on that element.
(2) the error message above seems to be complaining that the tag does
*not* have the namespace.
(3) That sure looks like the correct namespace for this element
according to the specification.

Weird. But not a high priority at the moment, so I'll leave things as
they are. I will modify the commit statement slightly, to indicate that
the problem was just tlddoc generation, not tld generation.

Thanks very much for figuring that out!

Regards,
Simon
> 

Reply via email to