[
https://issues.apache.org/jira/browse/TOMAHAWK-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633063#action_12633063
]
Paul Rivera commented on TOMAHAWK-1183:
---------------------------------------
I've attached the test cases and the results in testcases.rar here.
These basically test:
(w/o patch)
myfaces core 1.1
myfaces core 1.2
tomahawk 1.1
tomahawk 1.2
(w/ patch)
myfaces core 1.1
myfaces core 1.2
tomahawk 1.1
tomahawk 1.2
The tests cover both myfaces shared 2.0.x and 3.0.x.
In the spreadsheet included inside the zip file, you can see the test results
for all. In summary:
The patches originally provided (myfaces-shared-2.0.9.patch,
myfaces-shared-3.0.4.patch, and tomahawk-1.1.7.patch) have not introduced
additional bugs yet still fixes the bug in MYFACES-1608.
There are existing bugs uncovered:
- SelectOneRowRenderer: Onclick rendered multiple times.
- HtmlSwapImageRenderer: Onmouseover and onmouseout rendered multiple times.
(I will have to verify his one since onmouseout and onmouseover are not defined
in tomahawk.tld for the swapImage tag.)
> inputCalendar setfocus not working
> ----------------------------------
>
> Key: TOMAHAWK-1183
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1183
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Affects Versions: 1.1.6
> Environment: windows xp
> Reporter: richard lee
> Attachments: myfaces-shared-2.0.9.patch, myfaces-shared-3.0.4.patch,
> testcases.rar, testExampleOverMyfacesImpl.patch, tomahawk-1.1.7.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The inputCalendar tag / component is not rendering javascript entered for the
> setfocus property. I'm attempting to add some custom javascript to the
> setfocus of an inputcalendar to be run when the user clicks in the input box
> associated with the calendar, but this is being ignored during the redering
> of the input box. The only javascript that gets rendered is the "standard"
> javascript , i.e. onfocus="selectText('null', 'con9n')".
> I believe the issue is in HtmlTextHelpRenderer:
> if(isSelectText(component))
> {
> HtmlRendererUtils.renderHTMLAttributes(writer, component,
>
> HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS_AND_ONCLICK);
> writer.writeAttribute(HTML.ONFOCUS_ATTR,
>
> HtmlInputTextHelp.JS_FUNCTION_SELECT_TEXT + "('" +
> getHelpText(component) + "', '" + id
> +"')", null);
> writer.writeAttribute(HTML.ONCLICK_ATTR,
>
> HtmlInputTextHelp.JS_FUNCTION_SELECT_TEXT + "('" +
> getHelpText(component) + "', '" + id
> +"')", null);
> }
> when writing out the HTML.ONFOCUS_ATTR is should write out any user specified
> onfocus attributes as well as the standard ones.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
