[
https://issues.apache.org/jira/browse/TOMAHAWK-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633590#action_12633590
]
Leonardo Uribe commented on TOMAHAWK-1183:
------------------------------------------
Hi Paul
Thanks a lot for take a look at this in deep. I have checked the test and the
resume and I have some observations to do.
1. The patch it is ok, that task is necessary to make sure the changes
introduced are consistent, but for HtmlFormRendererTest, since shale-test 1.1.0
is not released yet, we need the following workaroud:
//fix for SHALE-468
public class MockTestViewHandler extends MockViewHandler
{
public void writeState(FacesContext context)
{
//Do not do anything.
}
}
public void setUp()
{
super.setUp();
//fix for SHALE-468
application.setViewHandler(new MockTestViewHandler());
after apply the patch, no test should fail (the idea is trunk must always
compile)
2. Some test has license header like this (the first is preferred):
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
Others this license:
/*
* Copyright 2006 The Apache Software Foundation.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
And others do not have anyone. Please update the patch so the new files had
just one unique license header.
3. TOMAHAWK-1335 and the problem with HtmlSwapImageRenderer should be solved
(with different patches and different issues ) at the same time we solve this.
4. Then it could be good to have this test for sandbox components too.
> inputCalendar setfocus not working
> ----------------------------------
>
> Key: TOMAHAWK-1183
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1183
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Affects Versions: 1.1.6
> Environment: windows xp
> Reporter: richard lee
> Attachments: myfaces-shared-2.0.9.patch, myfaces-shared-3.0.4.patch,
> testcases.rar, testExampleOverMyfacesImpl.patch, tomahawk-1.1.7.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The inputCalendar tag / component is not rendering javascript entered for the
> setfocus property. I'm attempting to add some custom javascript to the
> setfocus of an inputcalendar to be run when the user clicks in the input box
> associated with the calendar, but this is being ignored during the redering
> of the input box. The only javascript that gets rendered is the "standard"
> javascript , i.e. onfocus="selectText('null', 'con9n')".
> I believe the issue is in HtmlTextHelpRenderer:
> if(isSelectText(component))
> {
> HtmlRendererUtils.renderHTMLAttributes(writer, component,
>
> HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS_AND_ONCLICK);
> writer.writeAttribute(HTML.ONFOCUS_ATTR,
>
> HtmlInputTextHelp.JS_FUNCTION_SELECT_TEXT + "('" +
> getHelpText(component) + "', '" + id
> +"')", null);
> writer.writeAttribute(HTML.ONCLICK_ATTR,
>
> HtmlInputTextHelp.JS_FUNCTION_SELECT_TEXT + "('" +
> getHelpText(component) + "', '" + id
> +"')", null);
> }
> when writing out the HTML.ONFOCUS_ATTR is should write out any user specified
> onfocus attributes as well as the standard ones.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
