+1 to the name
Is everyone ok with trinidadinternal plus a comment staying it is private being enough to make this 'private' so that we are free to remove it and/or change the default behavior after it has been tested long enough?
I'm ok with it.

Here's a link to the JIRA issue: https://issues.apache.org/jira/browse/TRINIDAD-1442

Jeanne

Korhan Bircan wrote, On 5/11/2009 4:07 PM PT:
Hello,
 
To implement Trinidad-1442 "Aggregate single image to send to client" I need a new context parameter to turn the feature on and off in case there are any bugs early on. I want to make it private and remove it once the feature is fully tested.  If the feature works properly it will help performance and should always be on.
 
Currently I'm using a parameter in web.xml called "org.apache.myfaces.trinidadinternal.ENABLE_IMAGE_AGGREGATION". What do you think about this?
 
The affected files are:
org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache.java
org.apache.myfaces.trinidadinternal.style.cache.ImageStrip.java (new)
org.apache.myfaces.trinidadinternal.style.cache.ImageStripIcon.java (new)
org.apache.myfaces.trinidadinternal.style.cache.ImageStripUtils.java (new)
org.apache.myfaces.trinidadinternal.style.util.CSSGenerationUtils.java
 
Thanks,
 
--
Korhan
650.506.7786

Reply via email to