[jira] Created: (TOMAHAWK-1447) Invalid JavaScript in myFacesUtils.js in function myFacesKupuFormSubmit()

[Lutz Ulruch (JIRA)]

Invalid JavaScript in myFacesUtils.js in function myFacesKupuFormSubmit()
-------------------------------------------------------------------------

                 Key: TOMAHAWK-1447
                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1447
             Project: MyFaces Tomahawk
          Issue Type: Bug
          Components: Html Editor
    Affects Versions: 1.1.9
            Reporter: Lutz Ulruch


originalFormOnSubmit should by a local var and the function should always 
return a value:

original faulty code:

function myFacesKupuFormSubmit(){
        for(var i=0 ; i<myFacesKupuFormsIds.length ; i++){
                
myFacesKupuEditors.prepareForm(document.forms[myFacesKupuFormsIds[i]], 
myFacesKupuClientIDs[i]);
        }

        originalFormOnSubmit = myFacesKupuOriginalFormsOnSubmits[0]; // TODO : 
Fix (How do we get the calling frame ??)
        if( originalFormOnSubmit )
                              return originalFormOnSubmit();
}

corrected:

function myFacesKupuFormSubmit(){
        for(var i=0 ; i<myFacesKupuFormsIds.length ; i++){
                
myFacesKupuEditors.prepareForm(document.forms[myFacesKupuFormsIds[i]], 
myFacesKupuClientIDs[i]);
        }

        var originalFormOnSubmit = myFacesKupuOriginalFormsOnSubmits[0]; // 
TODO : Fix (How do we get the calling frame ??)
        if( originalFormOnSubmit ) {
                return originalFormOnSubmit();
        }
        return true;
}




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.