Hi Marius,
I've looked at the code, and I think it will not be a problem to use it.
But I've some refactoring suggestions:
* What do you think about enums instead of constants for the agentName
and platformName
* It would be great when the version would be comparable (not
lexicographical like String)
Here is my +1 for having such module.
Regards,
Udo
Simon Lessard schrieb:
Hi,
I wouldn't mind seeing that part shared.
~ Simon
On Tue, Sep 22, 2009 at 5:30 PM, Udo Schnurpfeil <[email protected]
<mailto:[email protected]>> wrote:
Hi Marius,
it sounds very nice for me. Can I take a look to the
implementation anywhere? I would like to check if it fits to Tobago.
So we can share the code instead of reimplementing the same stuff
twice or more.
Regards,
Udo
Marius Petoi schrieb:
Hi everybody,
I would like to propose the creation of a new module in
MyFaces Commons, that will handle agent detection, a feature
which I hope you will consider, as such a module would be
useful to any component set out there (or at least to the ones
in MyFaces).
My work is based on what already exists in Trinidad: basically
I extracted the code from there and packaged it as a module
that integrates with the MyFaces Commons build; the
functionality is the same, I just refactored and cleaned up a
bit the code (the main change is that I extracted the
constants from the interfaces into separate classes). I
removed from this basic module the additional capabilities
support, which Trinidad has, as, in my opinion, this is
something specific for Trinidad (at least in this initial
version).
Also, I adapted Trinidad to work with this new module, I have
patches with all the modifications, in case you guys decide to
use the new module in Trinidad also (the current Trinidad
functionality doesn't change).
Would the community be interested in having this?
Regards,
Marius
