+1 - Mamallan
Blake Sullivan wrote:
+1 -- Blake Sullivan Matthias Wessendorf said the following On 1/13/2010 9:19 AM PT:On Wed, Jan 13, 2010 at 6:14 PM, Matt Cooper <[email protected]> wrote:Rather than having the casablanca skin as a separate jar file, I would prefer to see it built-into the Trinidad jars (part of the impl project) so consumers could use it out-of-the-box without any extra jar configuration.I want it to become default :-)Regards, Matt On Wed, Jan 13, 2010 at 10:02 AM, Catalin Kormos <[email protected]> wrote:Hi Jeanne, Thanks for the information, the thing is the custom resource loader is able to locate resource files in custom location, but the main entry point it is still the resource servlet, which intercepts the request to a /adf/* and then delegates to various resource loader to actually locate them, right? I was thinking maybe there is a feature like you can have EL expressions in the css, to resolve the context where the resource servlet is mapped... For now we will stick with the default /adf, i think this mapping of the resource servlet is required by other trinidad stuff also...so it's like a best practice to have it declared in web.xml. regards, Catalin On 1/13/10, Jeanne Waldman <[email protected]> wrote:Matthias Wessendorf wrote, On 1/12/2010 11:57 PM PT:On Tue, Jan 12, 2010 at 10:33 PM, Catalin Kormos <[email protected]> wrote:Hi, Was wondering if it would be possible to package a skin in its own jar file,yes, put the skinning xml/cfg in the JAR_FILE.jar/META-INF/so that we wouldn't need to package the skin witht the actual webapp that uses it, so that we could start having separate modules for skins?in theory yes.it would make sense for the new Casablanca skin IMHO. What do you think?I think we should make the new Casablance skin the default; the old skin we can place into a "skinning module" /trinidad-skins -/old-and-ugly-green-skin :-)About packaging skins, it seems possible, but I have a question: - for example in the skin's css file, if background image urls are specified, for example, with a property "background: white url(/adf/skins/casablanca/images/backgrounds/buttonLikeHeadHover.png) repeat-x bottom left;" this will work also when the images are packaged in a jar available in the classpath, but only if the Trinidad Resource Servlet is mapped to /adf/*; what happens if the servlet is mapped to another url pattern? is there another approach, mapping independent, or are we stuck with /adf?I think we are stuck with the (odd) /adf Regarding its refactoring, I think it takes quite a while and maybe error-prone. Jeanne may know more on that item.I would stick with /adf in your path since that is the easiest. If you want to use a different mapping, say /foo, then you probably have to do this (I haven't confirmed): 1. add a new foo.resources file to \META-INF\servlets\resources directory - currently there is an adf.resources file and it has this one entry org.apache.myfaces.trinidadinternal.resource.CoreRenderKitResourceLoader 2. add your new mapping to Trinidad's ResourceServlet to the web.xml. - currently there is: <servlet-mapping> <servlet-name>resources</servlet-name> <url-pattern>/adf/*</url-pattern> </servlet-mapping> 3. I don't think there are dependencies on /adf in any of Trinidad's ResourceLoaders, but if so, then you'll need to write your own ResourceLoader as well.-Matthiasregards, Catalin On Fri, Jan 8, 2010 at 12:11 PM, Catalin Kormos <[email protected]> wrote:Ok, sounds good. regards, Cata On 1/8/10, Matthias Wessendorf <[email protected]> wrote:once the JIRA is up, I will ping [email protected] regarding the software grant Note: this is only discussed at the incubator committee, but no incubation for that piece is needed. Maybe (only) a software grant. -M On Fri, Jan 8, 2010 at 11:00 AM, Catalin Kormos <[email protected]> wrote:Hey Matthias, Great :), we'll look into the tasks you mentioned. regards, Catalin On 1/8/10, Matthias Wessendorf <[email protected]> wrote:Hi Catalin et al, as promised, I hijacked the thread... thanks again for contributing this skin to Trinidad. The following tasks are needed: -A JIRA ticket that contains the patch(es) - for the Skin itself - for the GREAT demo => maybe a software grant is needed; If so, I will handle the paperwork stuff for you guys. Once the things above are sorted out, we can apply it to TRUNK. However, I'd like to do a RELEASE before we integrate the new Skin/Demo. I also don't mind to pretty much do a "sub-release" once the new stuff is in. (With maven, release are not expensive) Thanks, Matthias On Thu, Jan 7, 2010 at 11:37 PM, Catalin Kormos <[email protected]> wrote:Hello there, I have the pleasure to inform you about the work we did to develop a new skin for Trinidad and based on this a brand new, Trinidad components showcase application. You can see it all in action at [1]. It is still a working in progress, in advanced state though...i mean there is always something to be improved; nevertheless we would like to donate the new skin and the new demo application to the MyFaces community, in its current state, and continue there if you guys agree. Many thanks go to my collegue Adonis who has put a lot of effort into designing and implementing the new skin called 'Casablanca'. I'm sure he can give you more details as needed about how the process went. A few words about the new demo: first of all, many thanks to another collegue of mine, Cosmin, for his continuos efforts with this. the demo is working only with facelets (there is no jsp version) it uses the latest 1.2.13-SNAPSHOT version of Trinidad we tryied to build it so it can be searched online also, currently tryied with Google Custom Search, but this didn't work out so smoothly so far. In any case, that's the reason for the pretty urls used. (so, no point in trying the search currently as it doesn't work). in general, it replicates the examples available already for Trinidad in the existing demo, in someplaces slightly improved. it tryies to provide a platform on which to build much more demos as required as there can be always new ideas about demoing a meaningfull use case on Trinidad, or some component behaviour. I'm eager to get your reactions, I think these guys did a great job so far and this would bring Trinidad at least a few steps closer to a more appealing and user friendly component set. regards, Catalin [1] http://example.irian.at/trinidad-showcase-casablanca ------------ Codebeat www.codebeat.ro-- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf-- ------------ Codebeat www.codebeat.ro-- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf-- ------------ Codebeat www.codebeat.ro-- ------------ Codebeat www.codebeat.ro-- ------------ Codebeat www.codebeat.ro
