[
https://issues.apache.org/jira/browse/TRINIDAD-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836942#action_12836942
]
Jeanne Waldman commented on TRINIDAD-1680:
------------------------------------------
A couple things are needed before I review.
1. This code needs to be formatted. } are on their own line. No tabs, 2 spaces
per 'tab' instead. Looking at this in JDeveloper the indents seem to be all
over the place. You can download JDeveloper for free here:
http://www.oracle.com/technology/software/products/jdev/index.html. You can set
up the code format. I can help you if you decide to use JDev.
2. Please provide a test case. For example, you can add selectors to
purpleSkin.css, like this, to prove that this works.
/* test the new include property functionality */
.AFTestForegroundColor:alias {color: Lime;}
.AFTestBackgroundColor:alias {-tr-include-property:
property(selector=".AFTestForegroundColor:alias",propertyName="color",
localPropertyName="background-color")}
af|testBackgroundColor {-tr-include-property:
property(selector=".AFTestForegroundColor:alias",propertyName="color",
localPropertyName="background-color")}
/* this should be color: lime */
af|testColor {-tr-include-property:
property(selector=".AFTestBackgroundColor:alias",propertyName="background-color",
localPropertyName="color")}
(my initial tests made me believe this is not working, but I'll look closer
once you have reformatted, etc)
> Introduce include-property in CSS
> ---------------------------------
>
> Key: TRINIDAD-1680
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1680
> Project: MyFaces Trinidad
> Issue Type: New Feature
> Components: Skinning
> Reporter: Marius Petoi
> Priority: Minor
> Attachments: includeProperty.patch, patchIncludeProperty.patch
>
>
> The include-property feature is present in the XSS, but it is not supported
> in the CSS. With this, we are one step closer to eliminating the old XSS
> files and replacing them with CSS. In the XSS files, the syntax of
> includeProperty is:
> <!-- AFVeryDarkForeground is the darkest foreground color in the core (green)
> color ramp -->
> <style name="AFVeryDarkForeground">
> <includeProperty name="AFVeryDarkBackground"
> propertyName="background-color"
> localPropertyName="color"/>
> </style>
> This should be ported to CSS also.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
