[
https://issues.apache.org/jira/browse/TRINIDAD-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840075#action_12840075
]
Matthias Weßendorf commented on TRINIDAD-1680:
----------------------------------------------
the code should be formarted as the other Trinidad code does; requiring some
JDEV specific formating seems wrong for an Apache project.
In there we use two spaces, not four. no TAB etc.
In your patch:
https://issues.apache.org/jira/secure/attachment/12437587/includeProperty.patch
I see this:
+af|commandButton {
+ -tr-include-property:
property(selector=".AFTestBackgroundColor:alias",propertyName="background-color",localPropertyName="background-color");
+}
which uses 4 spaces.
the file in question (in SVN) is doing this:
af|panelTabbed::orientation-bottom
{
border-top: 3px solid black;
}
which is "just" two spaces.
Ideally we have check-style for all kind of formats. Otherwise we can't control
the format of patches... and denying patches just b/c of formarting issues is
IMO wrong, especially when there is no check-style at all :-)
> Introduce include-property in CSS
> ---------------------------------
>
> Key: TRINIDAD-1680
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1680
> Project: MyFaces Trinidad
> Issue Type: New Feature
> Components: Skinning
> Reporter: Marius Petoi
> Priority: Minor
> Attachments: includeProperty.patch, includeProperty.patch,
> patchIncludeProperty.patch
>
>
> The include-property feature is present in the XSS, but it is not supported
> in the CSS. With this, we are one step closer to eliminating the old XSS
> files and replacing them with CSS. In the XSS files, the syntax of
> includeProperty is:
> <!-- AFVeryDarkForeground is the darkest foreground color in the core (green)
> color ramp -->
> <style name="AFVeryDarkForeground">
> <includeProperty name="AFVeryDarkBackground"
> propertyName="background-color"
> localPropertyName="color"/>
> </style>
> This should be ported to CSS also.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
