[
https://issues.apache.org/jira/browse/TRINIDAD-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852157#action_12852157
]
Jeanne Waldman commented on TRINIDAD-1680:
------------------------------------------
I tested this with my existing skins before and after the change, and it looks
good except the hashcode has changed.
I think this is because we create an includePropertyNodes List regardless of if
there are properties.
For backward compatibilty sake (to keep hashcodes the same), I think we should
pass in null to if IncludePropertyNode isEmpty().
// create the included properties nodes.
List<IncludePropertyNode> includePropertyNodes =
new ArrayList<IncludePropertyNode>();
for (String includedProperty: includedProperties)
{
_addIncludedProperty(includedProperty, includePropertyNodes);
}
// create a StyleNode
StyleNode styleNode =
new StyleNode(name,
selector,
propertyArray,
includeStyleNodes.toArray(new IncludeStyleNode[0]),
includePropertyNodes.toArray(new IncludePropertyNode[0]),
inhibitedProperties);
> Introduce include-property in CSS
> ---------------------------------
>
> Key: TRINIDAD-1680
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1680
> Project: MyFaces Trinidad
> Issue Type: New Feature
> Components: Skinning
> Reporter: Marius Petoi
> Priority: Minor
> Attachments: includeProperty.patch, includeProperty.patch,
> includeProperty.patch, patchIncludeProperty.patch, patchIncludeProperty.patch
>
>
> The include-property feature is present in the XSS, but it is not supported
> in the CSS. With this, we are one step closer to eliminating the old XSS
> files and replacing them with CSS. In the XSS files, the syntax of
> includeProperty is:
> <!-- AFVeryDarkForeground is the darkest foreground color in the core (green)
> color ramp -->
> <style name="AFVeryDarkForeground">
> <includeProperty name="AFVeryDarkBackground"
> propertyName="background-color"
> localPropertyName="color"/>
> </style>
> This should be ported to CSS also.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
