[ 
https://issues.apache.org/jira/browse/MYFACES-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856418#action_12856418
 ] 

Jakob Korherr commented on MYFACES-2654:
----------------------------------------

Thanks Leo for pointing out that this kind of code is not allowed. Frankly, I 
did not know that!

The objection I have about this solution is that when someone uses a different 
(custom-built) VDL, the spec requirement is not fulfilled.

The spec says: "For partial requests, were partial view rendering is required 
there must be no content written outside of the view (outside f:view). Response 
writing must be disabled. Response writing must be enabled again at the start 
of encodeBegin."

Since the ResponseSwitch is a MyFaces implementation detail, we can't control 
it in UIViewRoot.encodeBegin() directly, because it would have to be specified. 
Also, as you said Leo, we can't put a field on the FacesContext attribute map 
(or any other map) to control MyFaces-impl behaviour. So maybe a phase listener 
is the right thing here, because phase listeners are the first thing that is 
executed in UIViewRoot.encodeBegin(). I'll provide a patch and we can talk 
about it!

> Trinidad ajax-branch does not work with MyFaces2
> ------------------------------------------------
>
>                 Key: MYFACES-2654
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2654
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 2.0.0-beta-3
>         Environment: Trinidad ajax branch, URL: 
> https://svn.apache.org/repos/asf/myfaces/trinidad/branches/jsf2_ajax.3/
> MyFaces TRUNK
>            Reporter: Matthias Weßendorf
>         Attachments: MYFACES-2654-2.patch, MYFACES-2654.patch
>
>
> run the demo (like via Jetty):
> Go to "http://localhost:8080/trinidad-demo/faces/demos/pprDemos.jspx";
> on any "ajax" action/click, I get these two alert() boxes:
> * "TypeError: this._ajaxOldDomElements is null"
> * "malformedXML--"
> Same stuff works with Mojarra 2.0.2

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to