Hi Marius It seems the optimization for ValueExpression / MethodExpression or ValueBinding / MethodBinding is not worth. The test data you provided shows a small improvement, but it does not take into account PartialStateHolder instances needs to be wrapped before save, so in the end the performance will be almost the same.
regards, Leonardo Uribe 2010/7/21 Martin Marinschek <[email protected]> > Hi Marius, > > > --> Take for instance MethodExpressionActionListener. This is an example > > where a MethodExpression is part of the state. > > then this should (and needs to be changed), right? > > >> Additionally, ValueExpression and MethodExpression are not implemented > >> by us, so how can you implement StateHolder in this classes? Only in > >> classes containing ValueExpressions, right? > > > > --> There are some implementations of MethodExpression and > ValueExpression > > in MyFaces, such as TagMethodExpression, which implement Externalizable. > > These were the classes I was referring to earlier. > > ok, but even then, the underlying value-expression will not be touched > by this changes. So your changes are only applying to a thin wrapper. > So this should be negligible. > > best regards, > > Martin > > -- > > http://www.irian.at > > Your JSF powerhouse - > JSF Consulting, Development and > Courses in English and German > > Professional Support for Apache MyFaces >
