On Wed, Aug 11, 2010 at 10:43 AM, Jakob Korherr <[email protected]> wrote: > Hi guys, > > +1 on removing all this stuff. > > Frankly I always added or changed the headers to include author and version > information, but only because I read it in the MyFaces developer notes [1] > and the referenced Struts svn guide [2] in the wiki. > > @Jan-Kees: "I don't really understand what you mean with config file?" > Take a look at the Struts svn guide [2] at the section "Configuring the > Client: Automatic Property Setting".
we do want to continue with the right config. -M > > Regards, > Jakob > > [1] http://wiki.apache.org/myfaces/MyFaces_Developer_Notes > [2] http://wiki.apache.org/struts/StrutsMaintenanceSvn > > 2010/8/11 Matthias Wessendorf <[email protected]> >> >> On Wed, Aug 11, 2010 at 9:31 AM, Matthias Wessendorf <[email protected]> >> wrote: >> > On Wed, Aug 11, 2010 at 9:21 AM, Ganesh <[email protected]> wrote: >> >> I'd like to keep the @author tags. Isn't the spirit of the meritocracy >> >> involved with making authors visible? >> > >> > Actually not... >> > There are a ton of discussions on this in the archives. >> > >> > Fact: there is no code ownership... >> >> >> http://mail-archives.apache.org/mod_mbox/jakarta-jmeter-dev/200402.mbox/%[email protected]%3e >> >> quote: >> >> - author tags are officially discouraged. these create difficulties in >> establishing the proper ownership and the protection of our >> committers. there are other social issues dealing with collaborative >> development, but the Board is concerned about the legal ramifications >> around the use of author tags >> >> >> (Greg Stein, formal ASF VP) >> >> >> > >> > >> > >> >> Shouldn't personal merit for a project >> >> be made visible in the code? I think it's great to see Manfred Geiler >> >> as the >> >> orginal author of most MyFaces parts. Many people download the source >> >> code >> >> without connecting to SVN, so SVN information may be unsufficient, also >> >> repackaging would delete original authorship. >> >> >> >> Matthias Wessendorf schrieb: >> >>> >> >>> On Wed, Aug 11, 2010 at 8:40 AM, Michael Kurz <[email protected]> >> >>> wrote: >> >>>> >> >>>> I would also get rid of the author tags too. I guess that in many >> >>>> cases >> >>>> they >> >>>> are not correct anyway as files are constantly changed. >> >>> >> >>> exactly, and still svn (blame) knows everything... Original committer >> >>> and who introduced all the bugs ;-) >> >>> >> >>>> Michael >> >>>> >> >>>> Am 11.08.2010 08:22, schrieb Matthias Wessendorf: >> >>>>> >> >>>>> On Tue, Aug 10, 2010 at 11:55 PM, Bernd Bohmann >> >>>>> <[email protected]> wrote: >> >>>>>> >> >>>>>> Hello, >> >>>>>> >> >>>>>> why we need the @author tag? >> >>>>>> I don't like code owner ship. >> >>>>> >> >>>>> well, some do. I am fine without. In fact a lot of Apache project do >> >>>>> so, >> >>>>> since >> >>>>> there is no "code-ownership". SVN has still all the information >> >>>>> >> >>>>>> Does your request mean we don't allow the svn:keywords=Date Author >> >>>>>> Id >> >>>>>> Revision HeadURL >> >>>>>> in the Subversion config file? >> >>>>> >> >>>>> I am sure the talk is *only* inside the Java files, and not removing >> >>>>> the metadata of the file. >> >>>>> >> >>>>> -M >> >>>>> >> >>>>>> Regards >> >>>>>> >> >>>>>> Bernd >> >>>>>> >> >>>>>> On Tue, Aug 10, 2010 at 10:00 PM, Jan-Kees van Andel >> >>>>>> <[email protected]> wrote: >> >>>>>>> >> >>>>>>> Hi, >> >>>>>>> >> >>>>>>> Sure. For example, take a look >> >>>>>>> at: >> >>>>>>> >> >>>>>>> >> >>>>>>> http://svn.apache.org/repos/asf/myfaces/core/trunk/api/src/main/java/javax/faces/FacesException.java >> >>>>>>> If we remove the SVN stuff, we'll end up with this JavaDoc >> >>>>>>> comment: >> >>>>>>> /** >> >>>>>>> * see Javadoc of<a >> >>>>>>> >> >>>>>>> >> >>>>>>> >> >>>>>>> href="http://java.sun.com/javaee/javaserverfaces/1.2/docs/api/index.html";>JSF >> >>>>>>> Specification</a> >> >>>>>>> * >> >>>>>>> * @author Manfred Geiler >> >>>>>>> */ >> >>>>>>> >> >>>>>>> Or for >> >>>>>>> example: >> >>>>>>> >> >>>>>>> >> >>>>>>> http://svn.apache.org/repos/asf/myfaces/core/trunk/api/src/main/java/javax/faces/application/Application.java >> >>>>>>> This would become: >> >>>>>>> /** >> >>>>>>> * ..... >> >>>>>>> * >> >>>>>>> * @author Manfred Geiler >> >>>>>>> * @author Stan Silvert >> >>>>>>> */ >> >>>>>>> >> >>>>>>> One last example, a class added in >> >>>>>>> 2.0: >> >>>>>>> >> >>>>>>> >> >>>>>>> http://svn.apache.org/repos/asf/myfaces/core/trunk/api/src/main/java/javax/faces/application/ResourceHandler.java >> >>>>>>> Which would end up like: >> >>>>>>> /** >> >>>>>>> * @author Simon Lessard >> >>>>>>> * @since 2.0 >> >>>>>>> */ >> >>>>>>> >> >>>>>>> What do you think? >> >>>>>>> BTW. I'm thinking of the best way to do this. I guess the best bet >> >>>>>>> is >> >>>>>>> to >> >>>>>>> do a massive find-replace on one project at a time. Generating a >> >>>>>>> patch >> >>>>>>> file >> >>>>>>> would be a nice way to check for possible errors... >> >>>>>>> Regards, >> >>>>>>> Jan-Kees >> >>>>>>> >> >>>>>>> >> >>>>>>> >> >>>>>>> 2010/8/10 Leonardo Uribe<[email protected]> >> >>>>>>>> >> >>>>>>>> Hi >> >>>>>>>> >> >>>>>>>> Could you provide an explicit example about how the header of >> >>>>>>>> java >> >>>>>>>> files >> >>>>>>>> should be? >> >>>>>>>> >> >>>>>>>> best regards, >> >>>>>>>> >> >>>>>>>> Leonardo >> >>>>>>> >> >>>>> >> >>>>> >> >>> >> >>> >> >>> >> >> >> >> -- >> >> "There are two kinds of people in the world, those who believe there >> >> are two >> >> kinds of people and those who don't." >> >> — Robert Benchley >> >> >> > >> > >> > >> > -- >> > Matthias Wessendorf >> > >> > blog: http://matthiaswessendorf.wordpress.com/ >> > sessions: http://www.slideshare.net/mwessendorf >> > twitter: http://twitter.com/mwessendorf >> > >> >> >> >> -- >> Matthias Wessendorf >> >> blog: http://matthiaswessendorf.wordpress.com/ >> sessions: http://www.slideshare.net/mwessendorf >> twitter: http://twitter.com/mwessendorf > > > > -- > Jakob Korherr > > blog: http://www.jakobk.com > twitter: http://twitter.com/jakobkorherr > work: http://www.irian.at > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
