[ 
https://issues.apache.org/jira/browse/TOMAHAWK-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005047#comment-13005047
 ] 

Cristian M commented on TOMAHAWK-1381:
--------------------------------------

Hey, I'm using the current version of tomahawk (1.1.10) but I'm facing the same 
problem.

I actually set the uploadMaxFileSize=1M, but when I choose a file greater than 
1 MB, nothing happens. Neither the console or the web page shows something.

What is that "cacheFileSizeErrors" ?  That parameter is on the 1.1.9 versión? 
Or that just works with the patch on this thread?

Thanks in advance!

> HtmlInputFileUpload does not fail gracefully when filesize exceeds 
> uploadMaxFileSize web.xml value
> --------------------------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-1381
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1381
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: File Upload
>    Affects Versions: 1.1.7, 1.1.8
>            Reporter: Phillip Webb
>            Assignee: Leonardo Uribe
>             Fix For: 1.1.9
>
>         Attachments: TOMAHAWK-1381-fileupload6.patch, file-upload.patch, 
> file-upload2.patch, testUsedForSolveTOMAHAWK1381.zip
>
>
> When uploading a file using the HtmlInputFileUpload that exceeds that 
> uploadMaxFileSize web.xml setting the system fails without error and no form 
> data is not processed by JSF.
> I think that there are a number of reasons for this:
> - There is a bug in commons-fileupload that prevents failures from being 
> handled correctly (see FILEUPLOAD-169)
> - MultipartRequestWrapper calls FileUploads setSizeMax, this is the size for 
> the total upload, and not individual files, it should call setFileSizeMax
> - HtmlFileUploadRenderer calls fileUpload.parseRequest(request), this will 
> fail if any size exceptions are thrown, it would be better to use 
> fileUpload.getItemIterator and catch each exception.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to