[ 
https://issues.apache.org/jira/browse/TOMAHAWK-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007134#comment-13007134
 ] 

Leonardo Uribe commented on TOMAHAWK-1381:
------------------------------------------

In resume, if uploadMaxFileSize = uploadMaxSize with cacheFileSizeErrors = true 
and the file exceed that value, commons-fileupload does not recover from this 
error. If you want to receive an error message it is necessary that 
uploadMaxFileSize < uploadMaxSize, so if the file is between these values, 
recovery is possible. It is working as expected.

> HtmlInputFileUpload does not fail gracefully when filesize exceeds 
> uploadMaxFileSize web.xml value
> --------------------------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-1381
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1381
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: File Upload
>    Affects Versions: 1.1.7, 1.1.8
>            Reporter: Phillip Webb
>            Assignee: Leonardo Uribe
>             Fix For: 1.1.9
>
>         Attachments: TOMAHAWK-1381-fileupload6.patch, file-upload.patch, 
> file-upload2.patch, testUsedForSolveTOMAHAWK1381.zip
>
>
> When uploading a file using the HtmlInputFileUpload that exceeds that 
> uploadMaxFileSize web.xml setting the system fails without error and no form 
> data is not processed by JSF.
> I think that there are a number of reasons for this:
> - There is a bug in commons-fileupload that prevents failures from being 
> handled correctly (see FILEUPLOAD-169)
> - MultipartRequestWrapper calls FileUploads setSizeMax, this is the size for 
> the total upload, and not individual files, it should call setFileSizeMax
> - HtmlFileUploadRenderer calls fileUpload.parseRequest(request), this will 
> fail if any size exceptions are thrown, it would be better to use 
> fileUpload.getItemIterator and catch each exception.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to