[ 
https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133947#comment-13133947
 ] 

Mark Struberg commented on MYFACES-3368:
----------------------------------------

Just as an explanation about _why_ I'm so picky about it.

I now need to get the myfaces-commons-resourcehandler running in my project. 
And while testing it, I found out that there are quite a few bugs caused by 

> if (..)
>    bums();
>    dings();

which of course always executes dings()

and particularry funny was

> while(..); 
> {
>     doSomething();
> }

which always executed doSomething() just once...

Both got correctly reported as error by our standard checkstyle rules. Having 
empty statements is just bad as is having if-statements without bracelets...
                
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
>                 Key: MYFACES-3368
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3368
>             Project: MyFaces Core
>          Issue Type: Improvement
>    Affects Versions: 2.1.3
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually 
> only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take 
> some time to fix (found 1111 errors only in the first module).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to