[ 
https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134930#comment-13134930
 ] 

Mark Struberg commented on MYFACES-3368:
----------------------------------------

Leo, 
I now finished the myfaces-core-api cleanup. There are now 7 checkstyle errors 
left in this module. I looked at them, but I'm honestly not sure if you would 
like the fix I would apply ;) Thus, can you please take a look yourself?

There are a few complicated inner assignments and a few 'equals without 
hashCode'. 

You can build myfaces-core with
%:> mvn clean install -Pcheckstyle

or if you only like to generate the checkstyle report alone:
%:> mvn checkstyle:check -Pcheckstyle

The checkstyle-report itself is available at 
%:> less target/checkstyle-result.xml

txs and LieGrue,
strub
                
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
>                 Key: MYFACES-3368
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3368
>             Project: MyFaces Core
>          Issue Type: Improvement
>    Affects Versions: 2.1.3
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually 
> only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take 
> some time to fix (found 1111 errors only in the first module).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to