[
https://issues.apache.org/jira/browse/ORCHESTRA-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237495#comment-13237495
]
Christian Kaltepoth commented on ORCHESTRA-60:
----------------------------------------------
Hi Leonardo,
thanks for looking into this issue. However I have a different opinion on this
topic.
I think PrettyFaces is correct when calling encodeRedirectURL() instead of
encodeURL(). The docs of encodeRedirectURL() clearly say "Encodes the specified
URL for use in the sendRedirect() method". PrettyFaces is calling
sendRedirect() to redirect inside the web application and therefore must call
encodeRedirectURL() to preserve session IDs. That's what the spec defines.
I also think that both methods are meant to be used only for URLs that point to
the same web application because the docs of both methods mention session IDs
as the primary thing that has to be encoded in the URL. Therefore it would be
not correct to call any of the encode methods on a URL that doesn't belong to
the same application. Therefore I see no reason why the conversion context ID
should not be added in encodeRedirectURL().
I'm looking forward to your thoughts on this.
Christian
> Orchestra should implement RequestParameterResponseWrapper.encodeRedirectURL()
> ------------------------------------------------------------------------------
>
> Key: ORCHESTRA-60
> URL: https://issues.apache.org/jira/browse/ORCHESTRA-60
> Project: MyFaces Orchestra
> Issue Type: Bug
> Components: Conversation
> Affects Versions: 1.5
> Reporter: Christian Kaltepoth
>
> Orchestra currently doesn't implement
> RequestParameterResponseWrapper.encodeRedirectURL(). The API docs of
> HttpServletResponse clearly state that encodeRedirectURL() should be called
> before sending a redirect using sendRedirect(). Therefore the
> conversationContext parameter is currently lost in these situations.
> Corresponding PrettyFaces issue:
> http://code.google.com/p/prettyfaces/issues/detail?id=125
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
