[ 
https://issues.apache.org/jira/browse/ORCHESTRA-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238509#comment-13238509
 ] 

Christian Kaltepoth commented on ORCHESTRA-60:
----------------------------------------------

Hey Leonardo,

yes, I think this is the way the API should be used. Calling sendRedirect() for 
external URLs is possible of cause, but calling encodeRedirectURL() only makes 
sense to me when being called for internal URLs. So I think it's safe to add 
the conversationContext parameter in encodeRedirectURL() too.

Christian
                
> Orchestra should implement RequestParameterResponseWrapper.encodeRedirectURL()
> ------------------------------------------------------------------------------
>
>                 Key: ORCHESTRA-60
>                 URL: https://issues.apache.org/jira/browse/ORCHESTRA-60
>             Project: MyFaces Orchestra
>          Issue Type: Bug
>          Components: Conversation
>    Affects Versions: 1.5
>            Reporter: Christian Kaltepoth
>
> Orchestra currently doesn't implement 
> RequestParameterResponseWrapper.encodeRedirectURL(). The API docs of 
> HttpServletResponse clearly state that encodeRedirectURL() should be called 
> before sending a redirect using sendRedirect(). Therefore the 
> conversationContext parameter is currently lost in these situations.
> Corresponding PrettyFaces issue:
> http://code.google.com/p/prettyfaces/issues/detail?id=125

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to