[ 
https://issues.apache.org/jira/browse/TOBAGO-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15728218#comment-15728218
 ] 

Hudson commented on TOBAGO-1652:
--------------------------------

SUCCESS: Integrated in Jenkins build Tobago 3.0.x #666 (See 
[https://builds.apache.org/job/Tobago%203.0.x/666/])
TOBAGO-1652: Improve code coverage of enums (lofwyr: 
[http://svn.apache.org/viewvc/?view=rev&rev=1773027])
* (delete) 
tobago-3.0.x/tobago-core/src/test/java/org/apache/myfaces/tobago/renderkit/css/TobagoClassUniTest.java
* (add) 
tobago-3.0.x/tobago-core/src/test/java/org/apache/myfaces/tobago/renderkit/css/TobagoClassUnitTest.java
TOBAGO-1652: Improve code coverage of enums
* add UnitTests for enums
[developed by hnoeth] (lofwyr: 
[http://svn.apache.org/viewvc/?view=rev&rev=1773026])
* (edit) 
tobago-3.0.x/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/SheetTagDeclaration.java
* (edit) 
tobago-3.0.x/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/TreeListboxTagDeclaration.java
* (edit) 
tobago-3.0.x/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/TreeTagDeclaration.java
* (edit) 
tobago-3.0.x/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/declaration/HasSanitize.java
* (edit) 
tobago-3.0.x/tobago-core/src/main/java/org/apache/myfaces/tobago/model/Selectable.java
* (edit) 
tobago-3.0.x/tobago-core/src/main/java/org/apache/myfaces/tobago/sanitizer/SanitizeMode.java
* (add) 
tobago-3.0.x/tobago-core/src/test/java/org/apache/myfaces/tobago/layout/JustifyContentUnitTest.java
* (add) 
tobago-3.0.x/tobago-core/src/test/java/org/apache/myfaces/tobago/model/SelectableUnitTest.java
* (add) 
tobago-3.0.x/tobago-core/src/test/java/org/apache/myfaces/tobago/model/SwitchTypeUnitTest.java
* (add) 
tobago-3.0.x/tobago-core/src/test/java/org/apache/myfaces/tobago/sanitizer
* (add) 
tobago-3.0.x/tobago-core/src/test/java/org/apache/myfaces/tobago/sanitizer/SanitizeModeUnitTest.java
* (edit) 
tobago-3.0.x/tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/SheetConfig.java


> Improve code coverage of enums
> ------------------------------
>
>                 Key: TOBAGO-1652
>                 URL: https://issues.apache.org/jira/browse/TOBAGO-1652
>             Project: MyFaces Tobago
>          Issue Type: Task
>            Reporter: Udo Schnurpfeil
>            Assignee: Henning Noeth
>            Priority: Trivial
>             Fix For: 3.0.0
>
>
> There are some enums which define constants, and have not only one string (by 
> technical reasons), like TobagoClass. These classes should automatically 
> tested by a UnitTest for consistency.
> org.apache.myfaces.tobago.util.EnumUnitTest is a good utils as parent class 
> for the test.
> By the way. These 2nd constant might be generated by the constructor, but 
> this is often not possible or the best way.
> E. g. 
> # String constants, that want to be used by annotations (CollapseMode), can't 
> be initialized by code. 
> # For CSS class names (TobagoClass), in my opinion, it's nice to have a way 
> to use a string search over the complete Java sources (e.g. 
> "tobago-flexLayout" will find the enum FLEX_LAYOUT, which can be find by the 
> IDE). If you would generate the CSS name, you must know internal details of 
> the code to analyse the usage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to