[ 
https://issues.apache.org/jira/browse/TOBAGO-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748361#comment-15748361
 ] 

Hudson commented on TOBAGO-1652:
--------------------------------

SUCCESS: Integrated in Jenkins build Tobago 3.0.x #690 (See 
[https://builds.apache.org/job/Tobago%203.0.x/690/])
TOBAGO-1652 Improve code coverage of enums
* add test for TobagoClass - deprecated enums will be ignored
[developed by hnoeth] (lofwyr: 
[http://svn.apache.org/viewvc/?view=rev&rev=1774205])
* (edit) 
tobago-3.0.x/tobago-core/src/test/java/org/apache/myfaces/tobago/renderkit/css/TobagoClassUnitTest.java


> Improve code coverage of enums
> ------------------------------
>
>                 Key: TOBAGO-1652
>                 URL: https://issues.apache.org/jira/browse/TOBAGO-1652
>             Project: MyFaces Tobago
>          Issue Type: Task
>            Reporter: Udo Schnurpfeil
>            Assignee: Henning Noeth
>            Priority: Trivial
>             Fix For: 3.0.1
>
>
> There are some enums which define constants, and have not only one string (by 
> technical reasons), like TobagoClass. These classes should automatically 
> tested by a UnitTest for consistency.
> org.apache.myfaces.tobago.util.EnumUnitTest is a good utils as parent class 
> for the test.
> By the way. These 2nd constant might be generated by the constructor, but 
> this is often not possible or the best way.
> E. g. 
> # String constants, that want to be used by annotations (CollapseMode), can't 
> be initialized by code. 
> # For CSS class names (TobagoClass), in my opinion, it's nice to have a way 
> to use a string search over the complete Java sources (e.g. 
> "tobago-flexLayout" will find the enum FLEX_LAYOUT, which can be find by the 
> IDE). If you would generate the CSS name, you must know internal details of 
> the code to analyse the usage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to