[ 
https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678634#comment-17678634
 ] 

Werner Punz edited comment on MYFACES-4533 at 1/19/23 11:16 AM:
----------------------------------------------------------------

Ok I did quickly all the needed changes on my 4466 branch where I host the new 
version of the scripts, the tests pass with my changes on the client side, and 
the changes on the server side.

However one test still fails, the navigational case  public void 
testSpec790WithNamespacedViewAjaxNavigation() which passes without naming 
container:

 
following construct does not seem to trigger the navigation but still reissues 
the same page in the namespaced case (non namespaced it works)

{code:xml}
<h:commandButton id="button" value="submit form and navigate to 
spec790WithNamespacedView.xhtml via Ajax" action="spec790WithNamespacedView">
                <f:ajax execute="@form" render="@this" />
            </h:commandButton>
{code}
 
The request seems correct to me, for safety reasons atm I pass the 
<namingcontanerId>:jakarta.faces.ViewState as well as jakarta.faces.ViewState 
in the request.
But on the bachend side the navigation does not seem to be triggered.

The Navigation Handler seems to be called, I will debug into what happens why 
it is not triggered.



was (Author: werpu):
Ok I did quickly all the needed changes on my 4466 branch where I host the new 
version of the scripts, the tests pass with my changes on the client side, and 
the changes on the server side.

However one test still fails, the navigational case  public void 
testSpec790WithNamespacedViewAjaxNavigation() which passes without naming 
container:

 
following construct does not seem to trigger the navigation but still reissues 
the same page in the namespaced case (non namespaced it works)

{code:xml}
<h:commandButton id="button" value="submit form and navigate to 
spec790WithNamespacedView.xhtml via Ajax" action="spec790WithNamespacedView">
                <f:ajax execute="@form" render="@this" />
            </h:commandButton>
{code}
 
The request seems correct to me, for safety reasons atm I pass the 
<namingcontanerId>:jakarta.faces.ViewState as well as jakarta.faces.ViewState 
in the request.
But on the bachend side the navigation does not seem to be triggered.

Any idea which class is responsible for triggering the backend navigation here, 
so that I can have a deeper look?



> TCK: Spec 790:  Viewstate input element's name attribute should be prefixed 
> with naming container id 
> -----------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-4533
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4533
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 4.0.0-RC2
>            Reporter: Volodymyr Siedlecki
>            Assignee: Werner Punz
>            Priority: Major
>         Attachments: image-2023-01-19-08-44-48-874.png, 
> image-2023-01-19-08-48-12-961.png, namespacedView.war
>
>
> Failing Line: 
> https://github.com/jakartaee/faces/blob/master/tck/faces23/namespacedView/src/test/java/ee/jakarta/tck/faces/test/javaee8/namespacedView/Spec790WithNamespacedViewIT.java#L15
>  5
> Generated Viewstate: 
> {code:java}
> <input type="hidden" name="jakarta.faces.ViewState" 
> id="j_id__v_0:jakarta.faces.ViewState:1" 
> value="NzVhMDlkOGYwNjY1ZWZkODAwMDAwMDAy" autocomplete="off">
> {code}
> The test expects the name attribute to be prefixed with `j_id__v_0`.  My 
> understanding is this should only apply when the view root is an instance of 
> a NamingContainer.   
> The test app's faces-config has the following configuration: 
> https://github.com/jakartaee/faces/blob/master/tck/faces23/namespacedView/src/main/webapp/WEB-INF/faces-config.xml#L25-L28



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to