[
https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678756#comment-17678756
]
Werner Punz edited comment on MYFACES-4533 at 1/19/23 3:17 PM:
---------------------------------------------------------------
I have added my current state
https://github.com/werpu/myfaces/tree/feature/MYFACES-4466-TCK790 you can fork
away from there for further research.
The code uses the new Ajax codebase and is also based on Master for the rest.
The TCK passes, however the navigational test of the Namespaced TCK fails. I
tried to debug into it and it seems like the Nav Handler is not called, and the
original page is returned.
If you have time please debug further in.
Also i have eliminated the namedResponse attribute as it is non standard and
solved it with a Dom pattern match hence reducing the changed classes on the
server side, down to one.
I am now out of office until tomorrow, if someone overseas wants to take over
for the next step (debugging out why the navigation fails, please feel free)
Once we have everything working in the new codebase I will backport the fix to
the old code!
was (Author: werpu):
I have added my current state
https://github.com/werpu/myfaces/tree/feature/MYFACES-4466-TCK790 you can fork
away from there from further research.
The code uses the new ajax codebase and is also based on master for the rest.
The TCK passes, however the navigational test of the Namespaced TCK fails. I
tried to debug into it and it seems like the Nav Handler not called and the
original page is returned.
If you have time please debug further in.
Also i have eliminated the namedResponse attribute as it is non standard and
solved it with a dom pattern match.
I am now out of work, if someone overseas wants to take over for the next step
(debugging out why the navigation fails, please feel free)
Once we have everything working in the new codebase I will backport the fix to
the old code!
> TCK: Spec 790: Viewstate input element's name attribute should be prefixed
> with naming container id
> -----------------------------------------------------------------------------------------------------
>
> Key: MYFACES-4533
> URL: https://issues.apache.org/jira/browse/MYFACES-4533
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 4.0.0-RC2
> Reporter: Volodymyr Siedlecki
> Assignee: Werner Punz
> Priority: Major
> Attachments: image-2023-01-19-08-44-48-874.png,
> image-2023-01-19-08-48-12-961.png, namespacedView.war
>
>
> Failing Line:
> https://github.com/jakartaee/faces/blob/master/tck/faces23/namespacedView/src/test/java/ee/jakarta/tck/faces/test/javaee8/namespacedView/Spec790WithNamespacedViewIT.java#L15
> 5
> Generated Viewstate:
> {code:java}
> <input type="hidden" name="jakarta.faces.ViewState"
> id="j_id__v_0:jakarta.faces.ViewState:1"
> value="NzVhMDlkOGYwNjY1ZWZkODAwMDAwMDAy" autocomplete="off">
> {code}
> The test expects the name attribute to be prefixed with `j_id__v_0`. My
> understanding is this should only apply when the view root is an instance of
> a NamingContainer.
> The test app's faces-config has the following configuration:
> https://github.com/jakartaee/faces/blob/master/tck/faces23/namespacedView/src/main/webapp/WEB-INF/faces-config.xml#L25-L28
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
