Hi, Turns out these failures were infrastructure related. Manual tests show that they pass.
I'll change vote to a +1. If no objections, I'll release 4.0.1 tomorrow? Best, Volodymyr On 2023/05/22 13:39:11 Volodymyr Siedlecki via dev wrote: > Hey Thomas, > > Yes, the TCK tests were passing previously on 4.0.0. I haven’t investigated > into the root causes yet, but I’ll look soon. > > Thanks, > > Volodymyr > > From: Thomas Andraschko <[email protected]> > Date: Monday, May 22, 2023 at 4:05 AM > To: MyFaces Development <[email protected]> > Subject: [EXTERNAL] Re: [VOTE] Release of MyFaces Core 4.0.1 > and they are working on 4. 0. 0? Am So. , 21. Mai 2023 um 03: 23 Uhr schrieb > Volodymyr Siedlecki <volosied@ apache. org>: Sorry, I linked the classes, not > the tests. Here are the 7 failing tests (from the old tck): com. sun. ts. > tests. jsf. spec. appconfigresources. absolute_ordering. URLClient > ZjQcmQRYFpfptBannerStart > This Message Is From an Untrusted Sender > You have not previously corresponded with this sender. > ZjQcmQRYFpfptBannerEnd > and they are working on 4.0.0? > > Am So., 21. Mai 2023 um 03:23 Uhr schrieb Volodymyr Siedlecki > <[email protected]<mailto:[email protected]>>: > Sorry, I linked the classes, not the tests. Here are the 7 failing tests > (from the old tck): > > com.sun.ts.tests.jsf.spec.appconfigresources.absolute_ordering.URLClient > - testDocumentAbsoluteOrdering > com.sun.ts.tests.jsf.spec.appconfigresources.relative_ordering.URLClient > - testDocumentRelativeOrderingTest1 > com.sun.ts.tests.jsf.spec.appconfigresources.startupbehavior.URLClient > - applicationConfigurationfilesTest1 > - applicationConfigurationfilesTest2 > com.sun.ts.tests.jsf.spec.composite.insertchildren.URLClient > - compositeRenderUsingPageChildrenTagTest > com.sun.ts.tests.jsf.spec.coretags.selectitems.URLClient > - selectItemsValueTest > com.sun.ts.tests.jsf.spec.coretags.viewaction.URLClient > - viewActionTest > > On 2023/05/21 01:18:57 Volodymyr Siedlecki wrote: > > -1 for me. TCK results finally got back (sorry for the delay) and we have > > failures for the following tests: > > > > com.sun.ts.tests.jsf.spec.appconfigresources.absolute_ordering.URLClient > > com.sun.ts.tests.jsf.spec.appconfigresources.relative_ordering.URLClient > > com.sun.ts.tests.jsf.spec.appconfigresources.startupbehavior.URLClient > > com.sun.ts.tests.jsf.spec.composite.insertchildren.URLClient > > com.sun.ts.tests.jsf.spec.coretags.selectitems.URLClient > > com.sun.ts.tests.jsf.spec.coretags.viewaction.URLClient > > > > I will need to investigate them. > > > > On 2023/05/18 00:41:36 Thomas Andraschko wrote: > > > +1 > > > > > > Melloware <[email protected]<mailto:[email protected]>> schrieb > > > am Mi., 17. Mai 2023, 22:11: > > > > > > > +1 > > > > > > > > > > > > On 5/17/2023 3:52 PM, Volodymyr Siedlecki wrote: > > > > > Hi, > > > > > > > > > > I was running the needed tasks to get the 4.0.1 release of Apache > > > > > MyFaces core out. > > > > > > > > > > Please note that this vote concerns all of the following parts: > > > > > 1. Maven artifact group "org.apache.myfaces.core" v4.0.1 [1] > > > > > > > > > > The artifacts were deployed on nexus repo [1] for binary and source > > > > > packages. > > > > > > > > > > The release notes could be found at [4]. > > > > > > > > > > The japicmp tool shows no binary incompatibilities with 4.0.1 when > > > > > compared to the previous 4.0.0 jar. Please take a look at the attached > > > > > results.html. > > > > > If requested, I can provide a comparison to the Jakarta Faces 4.0.1 > > > > > API. > > > > > > > > > > This release has not yet been run against the TCK, but I am working to > > > > > create a build which will run against the TCK. I hope to have results > > > > > by May 19. > > > > > > > > > > Please take a look at the "4.0.1" artifacts and vote! (see [3]) > > > > > > > > > > Please note: This vote is "majority approval" with a minimum of three > > > > > +1 votes (see [2]). > > > > > > > > > > ------------------------------------------------ > > > > > [ ] +1 for community members who have reviewed the bits > > > > > [ ] +0 > > > > > [ ] -1 for fatal flaws that should cause these bits not to be > > > > > released, and why. > > > > > ------------------------------------------------ > > > > > > > > > > Thanks, > > > > > > > > > > Volodymyr > > > > > > > > > > [1] > > > > > > > > > https://repository.apache.org/content/repositories/orgapachemyfaces-1231/org/apache/myfaces/core/<https://repository.apache.org/content/repositories/orgapachemyfaces-1231/org/apache/myfaces/core/> > > > > > [2] > > > > > http://www.apache.org/foundation/voting.html#ReleaseVotes<http://www.apache.org/foundation/voting.html#ReleaseVotes> > > > > > [3] > > > > > > > > > https://repository.apache.org/content/repositories/orgapachemyfaces-1231/org/apache/myfaces/core/myfaces-core-assembly/<https://repository.apache.org/content/repositories/orgapachemyfaces-1231/org/apache/myfaces/core/myfaces-core-assembly/> > > > > > [4] > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12352978<https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12352978> > > > > > < > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12352978<https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12352978>> > > > > > > > > > > > > > > > > > -- > > > > Melloware > > > > melloware@ > > > > > > > > > > > > > >
