> On Oct 27, 2015, at 7:38 AM, will sanfilippo <[email protected]> wrote: > > Regarding assert() and assert_debug(). Where would you put the dir “sys”? Why > not put the definitions in an os include dir? Is that due to dependencies you > would not want (i.e. os would need console, or something like that)? Or that > you dont feel like assert belongs in the os? >
I still would prefer to have the ability to build without OS, should the user so desire. E.g. bootloaders and such. These guys will most likely want to use HAL for accessing flash and GPIOs. And I could imagine that HAL will end up having calls to assert(). Having it visible via header file only is ok, but then the implementation will have to be in a form of an inline function. Therefore I would not put ASSERT() in os. > About the names: I think someone was mentioning that assert normally gets > defined out if you define NDEBUG. Is that true? If that is the case, shouldnt > we keep that paradigm? I know we discussed this a bit but I cant recall what > we decided :-) That knob would be fine. NDEBUG is used widely for this.
