What would the pull request be in reference to? We aren't expecting the viper author to maintain two versions of his library, are we?
I have already made the necessary changes to viper and committed it to the mynewt-newt repository, but I am not sure if that is relevant to your request. By the way, the only change necessary is: - "github.com/spf13/viper" + "git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/viper" Chris On Mon, Feb 29, 2016 at 07:22:27PM -0800, Sterling Hughes wrote: > can we submit a pull request to the viper author? > > sterling > > On 2/29/16 7:21 PM, Christopher Collins (JIRA) wrote: > > > > [ > > https://issues.apache.org/jira/browse/MYNEWT-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > > ] > > > > Christopher Collins resolved MYNEWT-137. > > ---------------------------------------- > > Resolution: Fixed > > > > The solution was to rewrite the parts of yaml.v2 that we need. This wasn't > > as bad as it sounds because: > > * Most of yaml.v2 is actually MIT-licensed, as it is a direct port > > from the libyaml C library. > > * We only need to decode YAML, not encode. > > > > That said, this naive solution is still troubling. All libraries which > > depend on yaml.v2 need to be forked and changed so that they import our > > yaml library instead. In our current code base, viper is the only library > > which depends on yaml.v2, so the maintenance cost isn't horrible. > > > >> Replace YAML dependency in Newt tool > >> ------------------------------------ > >> > >> Key: MYNEWT-137 > >> URL: https://issues.apache.org/jira/browse/MYNEWT-137 > >> Project: Mynewt > >> Issue Type: Improvement > >> Components: Newt > >> Reporter: Sterling Hughes > >> Assignee: Christopher Collins > >> Priority: Blocker > >> Fix For: v0_8_0_beta2 > >> > >> > >> We need to replace the YAML dependency in the newt tool. Currently this > >> LGPL dependency is causing issues with building and distributing Newt. > > > > > > > > -- > > This message was sent by Atlassian JIRA > > (v6.3.4#6332) > >
