On Mon, Feb 29, 2016 at 07:32:08PM -0800, Sterling Hughes wrote: > On 2/29/16 7:29 PM, Christopher Collins wrote: > > What would the pull request be in reference to? We aren't expecting the > > viper author to maintain two versions of his library, are we? > > > > I have already made the necessary changes to viper and committed it to > > the mynewt-newt repository, but I am not sure if that is relevant to > > your request. > > > > By the way, the only change necessary is: > > > > - "github.com/spf13/viper" > > + "git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/viper" > > > > Wouldn't it be stripping out the LGPL dependencies from viper -- ie, you > imported only the MIT licensed source code? > > I don't think viper needs to be able to encode YAML, just decode it, right? > > I'm not terribly worried about the maintenance here, although I'd prefer > not to -- I'm just wondering if the viper guy wouldn't appreciate the > work.
I think I was a bit loose in my description of the issue. Viper doesn't contain any LGPL code; yaml.v2 does. Viper is only relevant because it depends on yaml.v2. The major change was to create a new yaml decoding library. To ensure the new library gets used, viper needed a one line change (import our library rather than yaml.v2). I'm not sure if that clarifies anything... I might be the one in need of clarification! Chris
