Hey Chris,
On 29 May 2016, at 13:14, Christopher Collins wrote:
I'm attaching git diffs between the following two revisions:
a: commit when BSD license text was added (mbed repo)
b: first commit to the mynewt core repo.
The Mynewt files are "b" in the attached diffs. That is, "+++" are
changes added by Mynewt; "---" is removed by mbed.
Of course I attached the wrong diffs. Here are the correct ones.
Sorry about that!
Chris
Thanks for doing this.
Given that we’ve already released multiple versions of Mynewt with
CMSIS header files, we’re releasing a 0.9 and ARM has pretty much
licensed every other version of this header file under a BSD license in
recent years — I’d vote that we add an item in the NOTICE file, and
release. This is an area where we’re not wholly in accordance with
policy, but I think the risk to the end user is very low, and all of our
previous releases have had this issue.
For reference, the file that is being changed contains offsets to
interrupt vectors on ARM platforms. The new (correctly) licensed
functions look perfectly fine to me, and I think post release (and in
develop) we should replace these files. But I’d like to have some run
time with them (more than a few days), prior to releasing, in case
anything subtle occurs that we don’t catch in our regression tests.
Justin/Chris — would that be fine for you?
Sterling
