If you're tightening up coding standards, I'd suggest running "go fmt" before pushing in the newt repo.
Adam On Fri, Nov 4, 2016 at 6:01 PM, Sterling Hughes <[email protected]> wrote: > > > On 4 Nov 2016, at 16:34, Christopher Collins wrote: > > > Hello all, > > > > We've been a bit inconsistent with our use of angled-brackets vs. quotes > > in #include directives. There is a simple rule for this one: use > > quotes for user headers; angled-brackets for headers supplied by the > > implementation. "Implementation" is a technical term meaning the > > combination of compiler, standard library, linker, assembler, etc. > > > > In other words, > > > > GOOD: > > > > #include <stdio.h> > > #include <assert.h> > > #include "os/os.h" > > > > BAD: > > > > #include <stdio.h> > > #include <assert.h> > > #include <os/os.h> > > > > BAD: > > > > #include "stdio.h" > > #include "assert.h" > > #include "os/os.h" > > > > +1 > > Let’s get this added to the CODING_STANDARDS > > :) > > sterling >
