sanha commented on a change in pull request #2: [NEMO-7] Intra-TaskGroup pipelining URL: https://github.com/apache/incubator-nemo/pull/2#discussion_r173051102
########## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/TaskGroupExecutor.java ########## @@ -60,13 +55,27 @@ private final DataTransferFactory channelFactory; private final MetricCollector metricCollector; - /** - * Map of task IDs in this task group to their readers/writers. - */ - private final Map<String, List<InputReader>> physicalTaskIdToInputReaderMap; - private final Map<String, List<OutputWriter>> physicalTaskIdToOutputWriterMap; + private final List<InputReader> inputReaders; + private final Map<InputReader, List<Task>> inputReaderToTasksMap; + private final Map<String, Iterator> idToSrcIteratorMap; + private final Map<String, List<Task>> srcIteratorIdToTasksMap; + private final Map<String, List<Task>> iteratorIdToTasksMap; + private final LinkedBlockingQueue<Pair<String, DataUtil.IteratorWithNumBytes>> partitionQueue; + private Map<OutputCollectorImpl, List<Task>> outputCollectorToDstTasksMap; + private final Set<String> finishedTaskIds; + private int numPartitions; + private Map<String, Readable> logicalTaskIdToReadable; + private Map<Task, TaskDataHandler> taskToDataHandlerMap; + + // For metrics + private long serBlockSize; + private long encodedBlockSize; private boolean isExecutionRequested; + private String logicalTaskIdPutOnHold; + + private static final String ITERATORID_PREFIX = "ITERATOR_"; + private static final AtomicInteger ITERATORID_GENERATOR = new AtomicInteger(0); public TaskGroupExecutor(final ScheduledTaskGroup scheduledTaskGroup, Review comment: Please add comments about the constructor and all methods. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
