sanha commented on a change in pull request #2: [NEMO-7] Intra-TaskGroup
pipelining
URL: https://github.com/apache/incubator-nemo/pull/2#discussion_r173049301
##########
File path:
runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/datatransfer/InputReader.java
##########
@@ -39,12 +39,15 @@
import java.util.stream.Collectors;
import java.util.stream.Stream;
import java.util.stream.StreamSupport;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* Represents the input data transfer to a task.
* TODO #492: Modularize the data communication pattern.
*/
public final class InputReader extends DataTransfer {
+ private static final Logger LOG =
LoggerFactory.getLogger(InputReader.class.getName());
private final int dstTaskIndex;
private final BlockManagerWorker blockManagerWorker;
Review comment:
Let's remove the `Nullable` and TODO in
[L64](https://github.com/apache/incubator-nemo/pull/2/files#diff-6e5f21bb9201dea0f42ed3126467ef34R64).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
