jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r189782362
########## File path: runtime/master/src/test/java/edu.snu.nemo.runtime.master/scheduler/BatchSingleJobSchedulerTest.java ########## @@ -73,8 +73,8 @@ private static final int EXECUTOR_CAPACITY = 20; - // This schedule index will make sure that task events are not ignored - private static final int MAGIC_SCHEDULE_ATTEMPT_INDEX = Integer.MAX_VALUE; + // Assume no failures + private static final int MAGIC_SCHEDULE_ATTEMPT_INDEX = 1; Review comment: `SCHEDULE_ATTEMPT_INDEX_WITH_NO_FAILURE`? Is `MAGIC_` keyword necessary? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
