jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the
operations on ExecutorRegistry atomic
URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r189683185
##########
File path:
runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/BatchSingleJobScheduler.java
##########
@@ -374,15 +379,16 @@ private void scheduleStage(final PhysicalStage
stageToSchedule) {
// attemptIdx is only initialized/updated when we set the stage's state to
executing
jobStateManager.onStageStateChanged(stageToSchedule.getId(),
StageState.State.EXECUTING);
- final int attemptIdx =
jobStateManager.getAttemptCountForStage(stageToSchedule.getId());
- LOG.info("Scheduling Stage {} with attemptIdx={}", new
Object[]{stageToSchedule.getId(), attemptIdx});
+ LOG.info("Scheduling Stage {}", stageToSchedule.getId());
// each readable and source task will be bounded in executor.
final List<Map<String, Readable>> logicalTaskIdToReadables =
stageToSchedule.getLogicalTaskIdToReadables();
taskIdsToSchedule.forEach(taskId -> {
blockManagerMaster.onProducerTaskScheduled(taskId);
final int taskIdx = RuntimeIdGenerator.getIndexFromTaskId(taskId);
+ final int attemptIdx =
jobStateManager.getCurrentAttemptIndexForTask(taskId);
+
LOG.debug("Enquing {}", taskId);
Review comment:
Enqueuing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
