wonook commented on a change in pull request #45: [NEMO-103] Implement RPC
between Client and Driver
URL: https://github.com/apache/incubator-nemo/pull/45#discussion_r195985453
##########
File path: runtime/driver/src/main/java/edu/snu/nemo/driver/NemoDriver.java
##########
@@ -135,15 +139,19 @@ public void onNext(final ActiveContext activeContext) {
final boolean finalExecutorLaunched =
runtimeMaster.onExecutorLaunched(activeContext);
if (finalExecutorLaunched) {
- startSchedulingUserApplication();
+ clientRPC.send(ControlMessage.DriverToClientMessage.newBuilder()
+
.setType(ControlMessage.DriverToClientMessageType.ResourceReady).build());
}
}
}
- private void startSchedulingUserApplication() {
+ /**
+ * Start user application.
+ */
+ public void startSchedulingUserApplication(final String dagString) {
// Launch user application (with a new thread)
final ExecutorService userApplicationRunnerThread =
Executors.newSingleThreadExecutor();
- userApplicationRunnerThread.execute(userApplicationRunner);
+ userApplicationRunnerThread.execute(() ->
userApplicationRunner.run(dagString));
Review comment:
Just asking: is this the more standard way of calling a runner now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
