wonook commented on a change in pull request #45: [NEMO-103] Implement RPC
between Client and Driver
URL: https://github.com/apache/incubator-nemo/pull/45#discussion_r195988229
##########
File path: client/src/main/java/edu/snu/nemo/client/JobLauncher.java
##########
@@ -102,13 +115,10 @@ public static void launchDAG(final DAG dag) {
if (jobAndDriverConf == null || deployModeConf == null || builtJobConf
== null) {
throw new RuntimeException("Configuration for launching driver is not
ready");
}
- final String serializedDAG =
Base64.getEncoder().encodeToString(SerializationUtils.serialize(dag));
- final Configuration dagConf = TANG.newConfigurationBuilder()
- .bindNamedParameter(JobConf.SerializedDAG.class, serializedDAG)
- .build();
+ serializedDAG =
Base64.getEncoder().encodeToString(SerializationUtils.serialize(dag));
// Launch and wait indefinitely for the job to finish
final LauncherStatus launcherStatus =
DriverLauncher.getLauncher(deployModeConf)
- .run(Configurations.merge(jobAndDriverConf, dagConf));
+ .run(jobAndDriverConf);
Review comment:
Is this the part where the launchDAG message is being sent to the driver?
I'm a little confused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
