jeongyooneo commented on a change in pull request #107: [NEMO-178] Zero-delay
task cloning
URL: https://github.com/apache/incubator-nemo/pull/107#discussion_r211090436
##########
File path:
runtime/common/src/main/java/edu/snu/nemo/runtime/common/RuntimeIdManager.java
##########
@@ -85,19 +86,32 @@ public static String generateTaskId(final int index, final
String stageId) {
* @return the generated ID
*/
public static String generateExecutorId() {
- return "Executor-" + executorIdGenerator.getAndIncrement();
+ return "Executor" + executorIdGenerator.getAndIncrement();
}
/**
- * Generates the ID for a block, whose data is the output of a task.
+ * Generates the ID for a block, whose data is the output of a task attempt.
*
* @param runtimeEdgeId of the block
- * @param producerTaskIndex of the block
+ * @param producerTaskId of the block
* @return the generated ID
*/
public static String generateBlockId(final String runtimeEdgeId,
- final int producerTaskIndex) {
- return BLOCK_PREFIX + runtimeEdgeId + BLOCK_ID_SPLITTER +
producerTaskIndex;
+ final String producerTaskId) {
+ return runtimeEdgeId + SPLITTER + getIndexFromTaskId(producerTaskId)
+ + SPLITTER + getAttemptFromTaskId(producerTaskId);
+ }
+
+ /**
+ * Generates the ID for a block, whose data is the output of a task.
+ *
+ * @param runtimeEdgeId of the block
+ * @param producerTaskIndex of the block
+ * @return the generated WILDCARD ID
Review comment:
Could you explain more about the usage and purpose of block wildcard id in
this comment, in the context of task cloning?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
