jeongyooneo commented on a change in pull request #107: [NEMO-178] Zero-delay
task cloning
URL: https://github.com/apache/incubator-nemo/pull/107#discussion_r211090412
##########
File path:
runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/datatransfer/InputReader.java
##########
@@ -128,32 +128,26 @@ public InputReader(final int dstTaskIndex,
final int numSrcTasks = this.getSourceParallelism();
final List<CompletableFuture<DataUtil.IteratorWithNumBytes>> futures = new
ArrayList<>();
for (int srcTaskIdx = 0; srcTaskIdx < numSrcTasks; srcTaskIdx++) {
- final String blockId = getBlockId(srcTaskIdx);
+ final String blockIdWildcard = generateWildCardBlockId(srcTaskIdx);
futures.add(
- blockManagerWorker.readBlock(blockId, getId(),
dataStoreProperty.get(), hashRangeToRead));
+ blockManagerWorker.readBlock(blockIdWildcard, getId(),
dataStoreProperty.get(), hashRangeToRead));
}
return futures;
}
- public RuntimeEdge getRuntimeEdge() {
- return runtimeEdge;
- }
-
/**
- * Get block id.
- *
- * @param taskIdx task index of the block
- * @return the block id
+ * @param producerTaskIndex to use.
+ * @return wildcard block id that corresponds to "ANY" task attempt of the
task index.
Review comment:
Could you explain more about the usage and purpose of block wildcard id in
this comment, in the context of task cloning?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
