sanha commented on a change in pull request #112: [NEMO-179] Delayed Task
Cloning
URL: https://github.com/apache/incubator-nemo/pull/112#discussion_r211806933
##########
File path:
runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/LocalitySchedulingConstraint.java
##########
@@ -115,13 +116,15 @@ public boolean testSchedulability(final
ExecutorRepresenter executor, final Task
}
return sourceLocations.contains(executor.getNodeName());
- } else { // Non-source task.
- final Optional<String> optionalIntermediateLoc =
getIntermediateDataLocation(task);
-
- if (getIntermediateDataLocation(task).isPresent()) {
- return optionalIntermediateLoc.get().equals(executor.getExecutorId());
- } else {
+ } else {
+ // Non-source task.
+ final List<String> intermediateLocations =
getIntermediateDataLocations(task);
+ if (intermediateLocations.isEmpty()) {
+ // Since there is no known location, we just schedule the task to any
executor.
return true;
+ } else {
+ // There is a know location(s), so we schedule to it(them).
Review comment:
know -> known?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
