sanha commented on a change in pull request #112: [NEMO-179] Delayed Task Cloning URL: https://github.com/apache/incubator-nemo/pull/112#discussion_r211807937
########## File path: compiler/optimizer/src/main/java/edu/snu/nemo/compiler/optimizer/pass/compiletime/annotating/UpfrontCloningPass.java ########## @@ -0,0 +1,49 @@ +/* + * Copyright (C) 2018 Seoul National University + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package edu.snu.nemo.compiler.optimizer.pass.compiletime.annotating; + +import edu.snu.nemo.common.dag.DAG; +import edu.snu.nemo.common.ir.edge.IREdge; +import edu.snu.nemo.common.ir.edge.executionproperty.CommunicationPatternProperty; +import edu.snu.nemo.common.ir.vertex.IRVertex; +import edu.snu.nemo.common.ir.vertex.executionproperty.ClonedSchedulingProperty; + +/** + * Set the ClonedScheduling property of source vertices, in an upfront manner. + */ +@Annotates(ClonedSchedulingProperty.class) +public final class UpfrontCloningPass extends AnnotatingPass { + /** + * Default constructor. + */ + public UpfrontCloningPass() { + super(UpfrontCloningPass.class); + } + + @Override + public DAG<IRVertex, IREdge> apply(final DAG<IRVertex, IREdge> dag) { + dag.getVertices().stream() + .filter(vertex -> dag.getIncomingEdgesOf(vertex.getId()) + .stream() + // TODO #198: Handle Un-cloneable Beam Sink Operators + // only shuffle receivers (for now... as particular Beam sink operators fail when cloned) + .anyMatch(edge -> edge.getPropertyValue(CommunicationPatternProperty.class).get() Review comment: Please throw exception with `orElseThrow` if there is no communication property. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
