johnyangk commented on a change in pull request #135: [NEMO-230] Emit collected
data when receiving watermark in GroupByKeyAndWindowTransform
URL: https://github.com/apache/incubator-nemo/pull/135#discussion_r229180002
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyAndWindowDoFnTransform.java
##########
@@ -144,7 +197,10 @@ public String toString() {
return sb.toString();
}
- private Iterable<TimerInternals.TimerData> getTimers(final
InMemoryTimerInternals timerInternals) {
+ /**
+ * Get timer data.
+ */
+ private List<TimerInternals.TimerData> getTimers(final
InMemoryTimerInternals timerInternals) {
Review comment:
getEligibleTimers?
getTriggeredTimers?
(It appears that we're collecting timers based on some properties)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
