johnyangk commented on a change in pull request #135: [NEMO-230] Emit collected
data when receiving watermark in GroupByKeyAndWindowTransform
URL: https://github.com/apache/incubator-nemo/pull/135#discussion_r229177328
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyAndWindowDoFnTransform.java
##########
@@ -171,35 +227,73 @@ public String toString() {
return timerData;
}
+ /**
+ * Maintains state internals and timer internals for keys.
+ */
+ final class StateAndTimerInternalsFactory {
+ private final InMemoryTimerInternalsFactory inMemoryTimerInternalsFactory;
Review comment:
Can this and the below variables be simply fields of
`GroupByKeyAndWindowDoFnTransform`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
