taegeonum commented on a change in pull request #159: [NEMO-216,251,259]
Support side inputs and windowing
URL: https://github.com/apache/incubator-nemo/pull/159#discussion_r234864094
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/DoFnTransform.java
##########
@@ -67,24 +62,22 @@ protected DoFn wrapDoFn(final DoFn initDoFn) {
}
@Override
- public void onData(final WindowedValue<InputT> data) {
+ public void onData(final Object data) {
Review comment:
keep `WindowedValue`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
