taegeonum commented on a change in pull request #159: [NEMO-216,251,259]
Support side inputs and windowing
URL: https://github.com/apache/incubator-nemo/pull/159#discussion_r234863944
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/SideInputElement.java
##########
@@ -16,31 +16,29 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.nemo.common.ir.edge.executionproperty;
+package org.apache.nemo.compiler.frontend.beam;
-import org.apache.nemo.common.ir.executionproperty.EdgeExecutionProperty;
-
-import java.io.Serializable;
+import org.apache.beam.sdk.util.WindowedValue;
/**
- * Edges with this property fetch a broadcast variable.
+ * {@link org.apache.nemo.compiler.frontend.beam.transform.DoFnTransform}
treats elements of this type as side inputs.
+ * TODO #289: Prevent using SideInputElement in UDFs
+ * @param <T> type of the side input value.
*/
-public final class BroadcastVariableIdProperty extends
EdgeExecutionProperty<Serializable> {
+public final class SideInputElement<T> {
+ private final int sideInputIndex;
+ private final WindowedValue<T> sideInputValue;
Review comment:
just `T` instead of `WindowedValue`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
