taegeonum commented on a change in pull request #159: [NEMO-216,251,259]
Support side inputs and windowing
URL: https://github.com/apache/incubator-nemo/pull/159#discussion_r235247573
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/AbstractDoFnTransform.java
##########
@@ -132,10 +145,14 @@ public final DoFn getDoFn() {
* Checks whether the bundle is finished or not.
* Starts the bundle if it is done.
*/
- protected final void checkAndInvokeBundle() {
+ final void checkAndInvokeBundle() {
if (bundleFinished) {
bundleFinished = false;
- doFnRunner.startBundle();
+ if (pushBackRunner == null) {
Review comment:
It looks like we use different start/finish bundle strategy for simple
DoFnRunner and pushBackRunner. Separating them into different methods would be
good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
