taegeonum commented on a change in pull request #159: [NEMO-216,251,259]
Support side inputs and windowing
URL: https://github.com/apache/incubator-nemo/pull/159#discussion_r234861508
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyAndWindowDoFnTransform.java
##########
@@ -195,11 +190,10 @@ private void emitOutputWatermark(final Watermark
inputWatermark) {
@Override
public void onWatermark(final Watermark inputWatermark) {
- checkAndInvokeBundle();
+ getSideInputHandler().trackCurWatermark(inputWatermark.getTimestamp());
Review comment:
Why do you call this method here? `GroupByKeyAndWindowDoFnTransform` has no
side inputs but call `sideInputHandler.trackCurWatermark`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
